[PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3

[Fabrizio Castro]

Hello Geert,

thank you for your feedback!

>
> Hi Fabrizio, Chris,
>
> On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro
> <fabrizio.castro at bp.renesas.com> wrote:
> > Signed-off-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
> > Signed-off-by: Chris Paterson <chris.paterson2 at renesas.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
>
> > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > @@ -11,6 +11,7 @@
> >  / {
> >         aliases {
> >                 serial0 = &scif0;
> > +               serial3 = &scifb1;
>
> Given this port is not labeled "serial3", but called "data uart", you may want
> to add a comment to avoid confusion:

It's a little bit confusing, isn't it? The lines related to such interface are named as UART0_x on the carrier board schematic, the section of the schematic that contains the header is named "data uart header", and the board documentation names it explicitly as "UART 3 - /dev/ttySC3 (SCIFB1)".

I don't think there is anything we can do to make this easier for the user really, is there? :D
If we decide to add a comment to serial 3, I guess we need to be consistent and add comments for the other serial interfaces too.
If you still prefer having a comment there I'll send a v2 and patch(es) for adding comments to the other interfaces, just let me know.

Thanks,
Fab

>
>     serial3 = &scifb1; /* data uart */
>
> >                 ethernet0 = &avb;
> >         };
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.