[RFCv2 PATCH 01/36] iommu: Keep track of processes and PASIDs
Jean-Philippe Brucker
jean-philippe.brucker at arm.com
Fri Oct 6 06:31:28 PDT 2017
IOMMU drivers need a way to bind Linux processes to devices. This is used
for Shared Virtual Memory (SVM), where devices support paging. In that
mode, DMA can directly target virtual addresses of a process.
Introduce boilerplate code for allocating process structures and binding
them to devices. Four operations are added to IOMMU drivers:
* process_alloc, process_free: to create an iommu_process structure and
perform architecture-specific operations required to grab the process
(for instance on ARM SMMU, pin down the CPU ASID). There is a single
iommu_process structure per Linux process.
* process_attach: attach a process to a device. The IOMMU driver checks
that the device is capable of sharing an address space with this
process, and writes the PASID table entry to install the process page
directory.
Some IOMMU drivers (e.g. ARM SMMU and virtio-iommu) will have a single
PASID table per domain, for convenience. Other can implement it
differently but to help these drivers, process_attach and process_detach
take a 'first' or 'last' parameter telling whether they need to
install/remove the PASID entry or only send the required TLB
invalidations.
* process_detach: detach a process from a device. The IOMMU driver removes
the PASID table entry and invalidates the IOTLBs.
process_attach and process_detach operations are serialized with a
spinlock. At the moment it is global, but if we try to optimize it, the
core should at least prevent concurrent attach/detach on the same domain.
(so multi-level PASID table code can allocate tables lazily without having
to go through the io-pgtable concurrency nightmare). process_alloc can
sleep, but process_free must not (because we'll have to call it from
call_srcu.)
At the moment we use an IDR for allocating PASIDs and retrieving contexts.
We also use a single spinlock. These can be refined and optimized later (a
custom allocator will be needed for top-down PASID allocation).
Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker at arm.com>
---
drivers/iommu/Kconfig | 10 ++
drivers/iommu/Makefile | 1 +
drivers/iommu/iommu-process.c | 225 ++++++++++++++++++++++++++++++++++++++++++
drivers/iommu/iommu.c | 1 +
include/linux/iommu.h | 24 +++++
5 files changed, 261 insertions(+)
create mode 100644 drivers/iommu/iommu-process.c
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index f3a21343e636..1ea5c90e37be 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -74,6 +74,16 @@ config IOMMU_DMA
select IOMMU_IOVA
select NEED_SG_DMA_LENGTH
+config IOMMU_PROCESS
+ bool "Process management API for the IOMMU"
+ select IOMMU_API
+ help
+ Enable process management for the IOMMU API. In systems that support
+ it, device drivers can bind processes to devices and share their page
+ tables using this API.
+
+ If unsure, say N here.
+
config FSL_PAMU
bool "Freescale IOMMU support"
depends on PCI
diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
index b910aea813a1..a2832edbfaa2 100644
--- a/drivers/iommu/Makefile
+++ b/drivers/iommu/Makefile
@@ -1,6 +1,7 @@
obj-$(CONFIG_IOMMU_API) += iommu.o
obj-$(CONFIG_IOMMU_API) += iommu-traces.o
obj-$(CONFIG_IOMMU_API) += iommu-sysfs.o
+obj-$(CONFIG_IOMMU_PROCESS) += iommu-process.o
obj-$(CONFIG_IOMMU_DMA) += dma-iommu.o
obj-$(CONFIG_IOMMU_IO_PGTABLE) += io-pgtable.o
obj-$(CONFIG_IOMMU_IO_PGTABLE_ARMV7S) += io-pgtable-arm-v7s.o
diff --git a/drivers/iommu/iommu-process.c b/drivers/iommu/iommu-process.c
new file mode 100644
index 000000000000..a7e5a1c94305
--- /dev/null
+++ b/drivers/iommu/iommu-process.c
@@ -0,0 +1,225 @@
+/*
+ * Track processes bound to devices
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Copyright (C) 2017 ARM Ltd.
+ *
+ * Author: Jean-Philippe Brucker <jean-philippe.brucker at arm.com>
+ */
+
+#include <linux/idr.h>
+#include <linux/iommu.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+
+/* Link between a domain and a process */
+struct iommu_context {
+ struct iommu_process *process;
+ struct iommu_domain *domain;
+
+ struct list_head process_head;
+ struct list_head domain_head;
+
+ /* Number of devices that use this context */
+ refcount_t ref;
+};
+
+/*
+ * Because we're using an IDR, PASIDs are limited to 31 bits (the sign bit is
+ * used for returning errors). In practice implementations will use at most 20
+ * bits, which is the PCI limit.
+ */
+static DEFINE_IDR(iommu_process_idr);
+
+/*
+ * For the moment this is an all-purpose lock. It serializes
+ * access/modifications to contexts (process-domain links), access/modifications
+ * to the PASID IDR, and changes to process refcount as well.
+ */
+static DEFINE_SPINLOCK(iommu_process_lock);
+
+/*
+ * Allocate a iommu_process structure for the given task.
+ *
+ * Ideally we shouldn't need the domain parameter, since iommu_process is
+ * system-wide, but we use it to retrieve the driver's allocation ops and a
+ * PASID range.
+ */
+static struct iommu_process *
+iommu_process_alloc(struct iommu_domain *domain, struct task_struct *task)
+{
+ int err;
+ int pasid;
+ struct iommu_process *process;
+
+ if (WARN_ON(!domain->ops->process_alloc || !domain->ops->process_free))
+ return ERR_PTR(-ENODEV);
+
+ process = domain->ops->process_alloc(task);
+ if (IS_ERR(process))
+ return process;
+ if (!process)
+ return ERR_PTR(-ENOMEM);
+
+ process->pid = get_task_pid(task, PIDTYPE_PID);
+ process->release = domain->ops->process_free;
+ INIT_LIST_HEAD(&process->domains);
+ kref_init(&process->kref);
+
+ if (!process->pid) {
+ err = -EINVAL;
+ goto err_free_process;
+ }
+
+ idr_preload(GFP_KERNEL);
+ spin_lock(&iommu_process_lock);
+ pasid = idr_alloc_cyclic(&iommu_process_idr, process, domain->min_pasid,
+ domain->max_pasid + 1, GFP_ATOMIC);
+ process->pasid = pasid;
+ spin_unlock(&iommu_process_lock);
+ idr_preload_end();
+
+ if (pasid < 0) {
+ err = pasid;
+ goto err_put_pid;
+ }
+
+ return process;
+
+err_put_pid:
+ put_pid(process->pid);
+
+err_free_process:
+ domain->ops->process_free(process);
+
+ return ERR_PTR(err);
+}
+
+static void iommu_process_release(struct kref *kref)
+{
+ struct iommu_process *process;
+ void (*release)(struct iommu_process *);
+
+ assert_spin_locked(&iommu_process_lock);
+
+ process = container_of(kref, struct iommu_process, kref);
+ release = process->release;
+
+ WARN_ON(!list_empty(&process->domains));
+
+ idr_remove(&iommu_process_idr, process->pasid);
+ put_pid(process->pid);
+ release(process);
+}
+
+/*
+ * Returns non-zero if a reference to the process was successfully taken.
+ * Returns zero if the process is being freed and should not be used.
+ */
+static int iommu_process_get_locked(struct iommu_process *process)
+{
+ assert_spin_locked(&iommu_process_lock);
+
+ if (process)
+ return kref_get_unless_zero(&process->kref);
+
+ return 0;
+}
+
+static void iommu_process_put_locked(struct iommu_process *process)
+{
+ assert_spin_locked(&iommu_process_lock);
+
+ kref_put(&process->kref, iommu_process_release);
+}
+
+static int iommu_process_attach(struct iommu_domain *domain, struct device *dev,
+ struct iommu_process *process)
+{
+ int err;
+ int pasid = process->pasid;
+ struct iommu_context *context;
+
+ if (WARN_ON(!domain->ops->process_attach || !domain->ops->process_detach))
+ return -ENODEV;
+
+ if (pasid > domain->max_pasid || pasid < domain->min_pasid)
+ return -ENOSPC;
+
+ context = kzalloc(sizeof(*context), GFP_KERNEL);
+ if (!context)
+ return -ENOMEM;
+
+ context->process = process;
+ context->domain = domain;
+ refcount_set(&context->ref, 1);
+
+ spin_lock(&iommu_process_lock);
+ err = domain->ops->process_attach(domain, dev, process, true);
+ if (err) {
+ kfree(context);
+ spin_unlock(&iommu_process_lock);
+ return err;
+ }
+
+ list_add(&context->process_head, &process->domains);
+ list_add(&context->domain_head, &domain->processes);
+ spin_unlock(&iommu_process_lock);
+
+ return 0;
+}
+
+static void iommu_context_free(struct iommu_context *context)
+{
+ assert_spin_locked(&iommu_process_lock);
+
+ if (WARN_ON(!context->process || !context->domain))
+ return;
+
+ list_del(&context->process_head);
+ list_del(&context->domain_head);
+ iommu_process_put_locked(context->process);
+
+ kfree(context);
+}
+
+/* Attach an existing context to the device */
+static int iommu_process_attach_locked(struct iommu_context *context,
+ struct device *dev)
+{
+ assert_spin_locked(&iommu_process_lock);
+
+ refcount_inc(&context->ref);
+ return context->domain->ops->process_attach(context->domain, dev,
+ context->process, false);
+}
+
+/* Detach device from context and release it if necessary */
+static void iommu_process_detach_locked(struct iommu_context *context,
+ struct device *dev)
+{
+ bool last = false;
+ struct iommu_domain *domain = context->domain;
+
+ assert_spin_locked(&iommu_process_lock);
+
+ if (refcount_dec_and_test(&context->ref))
+ last = true;
+
+ domain->ops->process_detach(domain, dev, context->process, last);
+
+ if (last)
+ iommu_context_free(context);
+}
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 3de5c0bcb5cc..b2b34cf7c978 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1264,6 +1264,7 @@ static struct iommu_domain *__iommu_domain_alloc(struct bus_type *bus,
domain->type = type;
/* Assume all sizes by default; the driver may override this later */
domain->pgsize_bitmap = bus->iommu_ops->pgsize_bitmap;
+ INIT_LIST_HEAD(&domain->processes);
return domain;
}
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 41b8c5757859..3978dc094706 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -94,6 +94,19 @@ struct iommu_domain {
void *handler_token;
struct iommu_domain_geometry geometry;
void *iova_cookie;
+
+ unsigned int min_pasid, max_pasid;
+ struct list_head processes;
+};
+
+struct iommu_process {
+ struct pid *pid;
+ int pasid;
+ struct list_head domains;
+ struct kref kref;
+
+ /* Release callback for this process */
+ void (*release)(struct iommu_process *process);
};
enum iommu_cap {
@@ -164,6 +177,11 @@ struct iommu_resv_region {
* @domain_free: free iommu domain
* @attach_dev: attach device to an iommu domain
* @detach_dev: detach device from an iommu domain
+ * @process_alloc: allocate iommu process
+ * @process_free: free iommu process
+ * @process_attach: attach iommu process to a domain
+ * @process_detach: detach iommu process from a domain. Remove PASID entry and
+ * flush associated TLB entries.
* @map: map a physically contiguous memory region to an iommu domain
* @unmap: unmap a physically contiguous memory region from an iommu domain
* @map_sg: map a scatter-gather list of physically contiguous memory chunks
@@ -197,6 +215,12 @@ struct iommu_ops {
int (*attach_dev)(struct iommu_domain *domain, struct device *dev);
void (*detach_dev)(struct iommu_domain *domain, struct device *dev);
+ struct iommu_process *(*process_alloc)(struct task_struct *task);
+ void (*process_free)(struct iommu_process *process);
+ int (*process_attach)(struct iommu_domain *domain, struct device *dev,
+ struct iommu_process *process, bool first);
+ void (*process_detach)(struct iommu_domain *domain, struct device *dev,
+ struct iommu_process *process, bool last);
int (*map)(struct iommu_domain *domain, unsigned long iova,
phys_addr_t paddr, size_t size, int prot);
size_t (*unmap)(struct iommu_domain *domain, unsigned long iova,
--
2.13.3
More information about the linux-arm-kernel
mailing list