[PATCH 3/5] firmware: arm_scpi: pre-populate dvfs info in scpi_probe

Heiner Kallweit hkallweit1 at gmail.com
Wed Oct 4 11:50:03 PDT 2017


Am 04.10.2017 um 12:10 schrieb Sudeep Holla:
> 
> 
> On 03/10/17 19:19, Heiner Kallweit wrote:
>> Am 03.10.2017 um 18:18 schrieb Sudeep Holla:
>>>
>>>
>>> On 03/10/17 17:00, Heiner Kallweit wrote:
> 
> [...]
> 
>>>>>>
>>>>>> Remove does for (i = 0; i < MAX_DVFS_DOMAINS && info->dvfs[i]; i++) {
>>>>>> and therefore stops at the first unpopulated domain and doesn't free
>>>>>> the memory for further populated domains. I'll provide a patch for
>>>>>> it.
>>>>>>
>>>>>
>>>>> Does that mean you are re-introducing scpi_remove ? I kind of liked
>>>>> removing it.
>>>>>
>>>> Sorry for the confusion. Then I'll go with the original approach and
>>>> just make sure that errors whilst populating dvfs info are ignored.
>>>>
>>>
>>> Indeed.
>>>
>>> If you are fine with the below fixup, then I can add it myself. Let me know.
>>>
>> Fine with me.
> 
> Thanks for confirming, pushed now[1]. Can you please double check if
> possible.
> 
Compiles and works fine here.
By the way, I have three more small patches which I think are improvements (YMMV).
Will submit them later today.




More information about the linux-arm-kernel mailing list