[PATCH v2] arm64: dts: renesas: r8a7795: Move nodes which have no reg property out of bus

[Simon Horman]

On Tue, Nov 28, 2017 at 10:04:00AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Nov 28, 2017 at 9:56 AM, Simon Horman <horms at verge.net.au> wrote:
> > On Mon, Nov 27, 2017 at 12:15:39PM +0100, Geert Uytterhoeven wrote:
> >> On Mon, Nov 27, 2017 at 12:04 PM, Simon Horman <horms at verge.net.au> wrote:
> >> > I just noticed that with this patch applied I now see:
> >> >
> >> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (interrupts_property): Missing interrupt-parent for /pmu_a57
> >> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (interrupts_property): Missing interrupt-parent for /pmu_a53
> >> > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb: Warning (interrupts_property): Missing interrupt-parent for /pmu_a57
> >> > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb: Warning (interrupts_property): Missing interrupt-parent for /pmu_a53arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (interrupts_property): Missing interrupt-parent for /timer
> >> >
> >> > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb: Warning (interrupts_property): Missing interrupt-parent for /timer
> >>
> >> Right, the "interrupt-parent = <&gic>;" inside the /soc node applies to child
> >> nodes of the /soc node only.
> >>
> >> You can find this in two ways:
> 
> s/find/fix/
> 
> >>
> >>   1. Add "interrupt-parent = <&gic>;" to the /pmu_a57 and /pmu_a53 nodes.
> >>   2. Switch those nodes from "interrupt" to "interrupts-extended", e.g. turn
> >>
> >>         interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> >>
> >>      into
> >>
> >>         interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> >>
> >> The latter is what e.g. arch/arm/boot/dts/armada-375.dtsi does.
> >
> > Thanks, I took option 1 as it seems consistent with the rest of the
> > Renesas DT files. I also added it to the /timer node.
> 
> Actually we recently had a discussion about this on IRC, triggered by a
> similar issue in board files (see e.g, Ethernet PHY interrupts).
> 
> Given the following comment:
> 
> drivers/of/irq.c:       /* Try the new-style interrupts-extended first */
> drivers/of/irq.c:       res = of_parse_phandle_with_args(device,
> "interrupts-extended",
> 
> I think it would be better to use interrupts-extended for individual/isolated
> use outside the /soc node.

Sure, will do.