[PATCH v5 19/20] KVM: arm/arm64: Get rid of kvm_timer_flush_hwstate

Andrew Jones drjones at redhat.com
Mon Nov 27 08:50:12 PST 2017


On Fri, Oct 27, 2017 at 10:34:40AM +0200, Christoffer Dall wrote:
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 132d39a..14c50d1 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -656,7 +656,6 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run)
>  
>  		local_irq_disable();
>  
> -		kvm_timer_flush_hwstate(vcpu);
>  		kvm_vgic_flush_hwstate(vcpu);
>  
>  		/*
> -- 
> 2.7.4

Hi Christoffer,

I realize this is already merged, but I have a question about the
above hunk. IIUC, the patch "KVM: arm/arm64: Move timer/vgic
flush/sync under disabled irq" only moved kvm_vgic_flush_hwstate()
under disabled irq because it had to be run after
kvm_timer_flush_hwstate(). Now that kvm_timer_flush_hwstate() is
gone can/should it be moved back out?

Thanks,
drew



More information about the linux-arm-kernel mailing list