[PATCH] arm64: dts: renesas: r8a7795: Move nodes which have no reg property out of bus

Simon Horman horms at verge.net.au
Thu Nov 23 01:46:58 PST 2017


On Thu, Nov 23, 2017 at 10:27:55AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Nov 20, 2017 at 12:01 PM, Simon Horman
> <horms+renesas at verge.net.au> wrote:
> > Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
> > The nodes that have been moved do not have any register properties and thus
> > shouldn't be placed on the bus.
> >
> > This problem is flagged by the compiler as follows:
> > $ make
> > ...
> >   DTC     arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb
> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (simple_bus_reg): Node /soc/pmu_a57 missing or empty reg/ranges property
> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (simple_bus_reg): Node /soc/pmu_a53 missing or empty reg/ranges property
> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (simple_bus_reg): Node /soc/timer missing or empty reg/ranges property
> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dtb: Warning (simple_bus_reg): Node /soc/thermal-zones missing or empty reg/ranges property
> 
> [...]
> 
> Thanks for your patch!
> 
> > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -126,6 +126,86 @@
> 
> The node above is called "cpus".
> 
> >                 };
> >         };
> >
> > +       pmu_a57 {
> 
> > +       };
> > +
> > +       pmu_a53 {
> 
> > +       };
> > +
> > +       timer {
> 
> > +       };
> > +
> > +       thermal-zones {
> 
> > +       };
> > +
> >         extal_clk: extal {
> >                 compatible = "fixed-clock";
> >                 #clock-cells = <0>;
> 
> Any sorting rules (alphabetically?) for nodes at the root level?

Now would be a good time to decide on an alternate on an order as
I plan to submit similar patches for several other SoCs.

I took used order they were already present (with other nodes) in the
cpu node. They appear to be sorted alphabetically. Should I keep that
sort order relative to existing nodes present in the root node?





More information about the linux-arm-kernel mailing list