[PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

Arvind Yadav arvind.yadav.cs at gmail.com
Mon Nov 20 08:26:21 PST 2017


The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com>
---
changes in v2 :
              Return keypad->irq insted of -ENXIO.
changes in v3 :
              Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes ib v4 :
              Return -ENXIO insted of keypad->irq. Which was not correct in v3.

 drivers/input/keyboard/ep93xx_keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..c6eb31a 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
 	}
 
 	keypad->irq = platform_get_irq(pdev, 0);
-	if (!keypad->irq) {
+	if (keypad->irq <= 0) {
 		err = -ENXIO;
 		goto failed_free;
 	}
-- 
2.7.4




More information about the linux-arm-kernel mailing list