[PATCH v3 5/5] misc serdev: w2sg0004: add debugging code and Kconfig
H. Nikolaus Schaller
hns at goldelico.com
Wed Nov 15 09:13:51 PST 2017
Hi Ladislav,
> Am 15.11.2017 um 17:42 schrieb Ladislav Michl <ladis at linux-mips.org>:
>
> On Wed, Nov 15, 2017 at 05:29:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi Andreas,
>>
>>> Am 15.11.2017 um 16:53 schrieb Andreas Färber <afaerber at suse.de>:
>>>
>>> Hi,
>>>
>>> Am 15.11.2017 um 16:19 schrieb H. Nikolaus Schaller:
>>>> This allows to set CONFIG_W2SG0004_DEBUG which will
>>>> make the driver report more activities and it will turn on the
>>>> GPS module during boot while the driver assumes that it
>>>> is off. This can be used to debug the correct functioning of
>>>> the hardware. Therefore we add it as an option to the driver
>>>> because we think it is of general use (and a little tricky to
>>>> add by system testers).
>>>>
>>>> Normally it should be off.
>>>> ---
>>>
>>> If you want to merge this, it is lacking a Sob.
>>
>> Whats is a "Sob" in this context (https://acronyms.thefreedictionary.com/SOB)?
>
> https://acronyms.thefreedictionary.com/Signed-Off-By
Ah, ok. Too obvious to associate :) Tnx.
I did never think about that this could be missing. And I don't know why :(
> Also please read Documentation/process/submitting-patches.rst
We have automated things by calling checkpatch but it somwhow failed here.
BR and thanks,
Nikolaus
More information about the linux-arm-kernel
mailing list