[PATCH v2] ARM: sa1100: simpad: Correct I2C GPIO offsets

Arnd Bergmann arnd at arndb.de
Fri Nov 10 07:17:26 PST 2017


On Fri, Nov 10, 2017 at 4:01 PM, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Fri, Nov 10, 2017 at 3:50 PM, Wolfram Sang <wsa at the-dreams.de> wrote:
>
>> Applied to for-next, thanks!
>
> Thanks man.
>
>> This from checkpatch makes sense to me:
>>
>> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b2e63555592f ("i2c: gpio: Convert to use descriptors")'
>> #21:
>> commit b2e63555592f81331c8da3afaa607d8cf83e8138
>
> I never understood that thingie, I thought the check was
> only there in order to stop Fixes: tags from running wild.
> But feel free to cut it if you want.

I have this in my ~/.gitconfig:

[core]
        abbrev = 12
[alias]
        fixes = show --format='Fixes: %h (\"%s\")' -s

So 'git fixes b2e63555592f81331c8da3afaa607d8cf83e8138' produces
Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")

which I then copy into a changelog as the last line, or use only the reference.

     Arnd



More information about the linux-arm-kernel mailing list