[PATCH] arm64/debug: don't duplicate filenames.

[Dave Martin]

On Thu, Nov 09, 2017 at 02:41:36PM +0000, Jamie Iles wrote:
> On Thu, Nov 09, 2017 at 02:31:22PM +0000, Dave Martin wrote:
> > On Thu, Nov 09, 2017 at 01:08:51PM +0000, Jamie Iles wrote:
> > > Hi Dave,
> > > 
> > > On Thu, Nov 09, 2017 at 12:35:04PM +0000, Dave Martin wrote:

[...]

> > > > Or is the linker not removing duplicates that some from the same source
> > > > file?
> > > 
> > > In my testing, yes, the linker is merging them.
> > 
> > So, playing devil's advocate here, what is this fixing?
> 
> It's caused some confusion looking at object files, it's certainly not a 
> critical bug!
> 
> > It doesn't really matter where in the toolchain the duplicates get
> > removed, just that it happens somewhere...
> > 
> > It looks like ld -r doesn't do the deduplication, so there may be a fair
> > amount of duplicates before the final linux of vmlinux -- which I guess
> > could be an issue if BUG() is used in macros that get expanded all over
> > the place.
> 
> Ah, interesting.  Testing with a loadable module, this means that there 
> are duplicates in modules.  With mainline:
> 
>   strings ./fs/ext4/ext4.ko | grep -c "inode\.c"
>   61
> 
> and with my patch:
> 
>   strings ./fs/ext4/ext4.ko | grep -c "inode\.c"
>   4
> 
> Thanks,
> 
> Jamie

That's a more convincing argument...  I had forgotten that modules
weren't fully linked.

So this does look like a good idea.  I have some comments, but I'll
reply to the original patch (where there is code).

Cheers
---Dave