[PATCH 3/3] ARM: early_printk: use printascii() rather than printch()

[Nicolas Pitre]

On Thu, 2 Nov 2017, Chris Brandt wrote:

> On Thursday, November 02, 2017 1, Nicolas Pitre wrote:
> > > > So, as far as ARM assembly in the Linux kernel goes, all constants
> > must
> > > > be preceded by # whether or not binutils requires it - no exceptions.
> > > > Please always test assembly changes with a binutils version that is
> > not
> > > > gratuitously broken!
> > >
> > > Somewhat ironic since Nicolas works for Linaro.
> > 
> > I'm not involved with the toolchain people though, other than using
> > their output.
> 
> That was the irony!
> 
> As in...
> Even if you built the code, you would have probably used a Linaro 
> toolchain and it would have worked like on my system.

Thing is... I *did* test it after I figured out I needed to turn off 
semihosting support. And the build failed.

>   Forget it.  (mailing lists are so dry when it comes to humor)

Life is tough.

> > They all fail, including the version that looks like the one you have.
> > 
> > Could you try that little test above on your side?
> 
> Yes, I also get a failure:
> 
> arm-linux-gnueabihf-as /tmp/t.s -o /tmp/t.o
> /tmp/t.s: Assembler messages:
> /tmp/t.s:2: Error: immediate expression requires a # prefix -- `mov r1,13'
> 
> But I think the answer is not that simple. 
> You have no command line options.

Would be good to figure out what option makes it accept no # and see if 
that can be avoided for kernel build.


Nicolas