[PATCH v2 1/5] dts: gpio_atmel: adapt binding doc to reality
Alexandre Belloni
alexandre.belloni at free-electrons.com
Wed May 31 02:52:47 PDT 2017
On 26/05/2017 at 21:07:03 +0200, Uwe Kleine-König wrote:
> The second cell in a gpio reference is used to pass GPIO_ACTIVE_LOW or
> GPIO_ACTIVE_HIGH. The gpio device can also be used as irq controller and
> a reference can contain the IRQ_TYPE_* values in the second cell.
>
> Signed-off-by: Uwe Kleine-König <uwe at kleine-koenig.org>
> ---
> On Fri, May 26, 2017 at 08:52:14PM +0200, Andrew Lunn wrote:
> > > +- interrupt-controller: Marks the device node as a GPIO controller.
> >
> > Interrupt controller, not GPIO controller.
> >
> > > +- #interrupt-cells: Should be two. The first cell is the pin number and the
> > > + second cell is used to specify irq type flags:
> > > + 1 = low-to-high edge triggered.
> > > + 2 = high-to-low edge triggered.
> > > + 4 = active high level-sensitive.
> > > + 8 = active low level-sensitive.
> >
> > Maybe just reference interrupts.txt?
>
> ack for both and changed in this v2.
>
> Thanks
> Uwe
>
> Documentation/devicetree/bindings/gpio/gpio_atmel.txt | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list