[PATCH v4 03/11] clk: bcm: Add clocks for Stingray SOC

Michael Turquette mturquette at baylibre.com
Thu May 25 14:33:08 PDT 2017


Hello Anup,

Quoting Anup Patel (2017-05-22 04:58:19)
> +#include <linux/kernel.h>
> +#include <linux/err.h>
> +#include <linux/clk-provider.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>

Are all of those headers really needed?

> +CLK_OF_DECLARE(sr_genpll3_clk, "brcm,sr-genpll3",
> +                       sr_genpll3_clk_init);

Why use CLK_OF_DECLARE here? You've got a proper platform driver here.

Regards,
Mike



More information about the linux-arm-kernel mailing list