[PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc
Shawn Guo
shawnguo at kernel.org
Sun May 21 04:00:37 PDT 2017
On Sun, May 21, 2017 at 09:40:25AM +0000, A.S. Dong wrote:
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo at kernel.org]
> > Sent: Sunday, May 21, 2017 5:31 PM
> > To: A.S. Dong
> > Cc: linux-gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > linus.walleij at linaro.org; stefan at agner.ch; Jacky Bai; Andy Duan;
> > kernel at pengutronix.de; Rob Herring; Mark Rutland;
> > devicetree at vger.kernel.org
> > Subject: Re: [PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl
> > binding doc
> >
> > On Fri, May 19, 2017 at 03:05:44PM +0800, Dong Aisheng wrote:
> > > i.MX 7ULP has three IOMUXC instances: IOMUXC0 for M4 ports,
> > > IOMUXC1 for A7 ports and IOMUXC DDR for DDR interface.
> > >
> > > This patch adds the IOMUXC1 support for A7.
> > >
> > > Cc: Rob Herring <robh+dt at kernel.org>
> > > Cc: Mark Rutland <mark.rutland at arm.com>
> > > Cc: devicetree at vger.kernel.org
> > > Cc: Linus Walleij <linus.walleij at linaro.org>
> > > Cc: Shawn Guo <shawnguo at kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong at nxp.com>
> > >
> > > ---
> > > ChangeLog:
> > > v1->v2:
> > > * add more descriptions in binding doc
> > > * add missed prefix for private properties.
> > > * move dt-bindings/pinctrl/imx7ulp-pinfunc.h to arch/arm/boot/dts
> > > ---
> > > .../bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 63 +++
> > > arch/arm/boot/dts/imx7ulp-pinfunc.h | 468
> > +++++++++++++++++++++
> >
> > Rather than being part of bindings doc patch, this pinfunc header should
> > be included in dts patches that add imx7ulp SoC support.
> >
>
> Okay.
> One question is that imx7ulp-pinfunc.h is mentioned in this binding doc,
> that means after this patch applied, users still can't see it if separate,
> Should we worry about this issue or not?
>
> + Refer to imx7ulp-pinfunc.h in in device tree source folder for all
> + available imx7ulp PIN_FUNC_ID.
Ah, okay, there is a reason to have it in the bindings doc patch. If
LinusW and Rob have no problem with it, I'm fine then.
Acked-by: Shawn Guo <shawnguo at kernel.org>
More information about the linux-arm-kernel
mailing list