[PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue May 16 05:34:46 PDT 2017
Hello,
On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote:
> +&cps_eth1 {
> + status = "okay";
> + phy = <&phy0>;
> + phy-mode = "sgmii";
> +};
It would be nice to indicate which connector is that, like is done in
the rest of this Device Tree file.
> +&ap_sdhci0 {
> + status = "okay";
> + bus-width = <8>;
> + no-1-8-v;
> + non-removable;
> +};
> +
> +&cpm_sdhci0 {
> + status = "okay";
> + bus-width = <4>;
> + no-1-8-v;
> + non-removable;
> +};
Same comment. Also, are they both really non-removable? I have a uSD
card connector on my MacchiatoBin board. It isn't covered by those new
entries ?
Also, fix the wording of MacchiatoBin in your commit title/commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list