[v2, 1/5] mmc: dt: add compatible into eSDHC required properties

[Y.B. Lu]

Hi Shawn,


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Friday, May 05, 2017 10:37 AM
> To: Y.B. Lu
> Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> ulf.hansson at linaro.org; Rob Herring; Catalin Marinas; Harninder Rai;
> Xiaobo Xie
> Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required
> properties
> 
> On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote:
> > This patch is to add compatible into eSDHC required properties.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu at nxp.com>
> > ---
> > Changes for v2:
> > 	- Added this patch.
> > ---
> >  Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> > b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> > index dedfb02..b04b248 100644
> > --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> > @@ -7,6 +7,7 @@ This file documents differences between the core
> > properties described  by mmc.txt and the properties used by the sdhci-
> esdhc driver.
> >
> >  Required properties:
> > +  - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc".
> 
> I think either supported <chip> or the compatible should be listed
> explicitly.
> 

[Lu Yangbo-B47093] I think the reason we use <chip> is to avoid listing too much chips, and to avoid doc updating if new chips are added.
The checkpatch script also had considered that.

Currently there're about 20 platforms with "fsl,<chip>-esdhc" compatible in kernel dts.
And the doc also provide an example.
Example:

sdhci at 2e000 {
        compatible = "fsl,mpc8378-esdhc", "fsl,esdhc";

Should we still need to list all ?

Thanks.

> Shawn
> 
> >    - interrupt-parent : interrupt source phandle.
> >    - clock-frequency : specifies eSDHC base clock frequency.
> >
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel