[PATCHv3] ARM: omap2+: Revert omap-smp.c changes resetting CPU1 during boot
tony at atomide.com
Tue Mar 28 13:12:15 PDT 2017
* Russell King - ARM Linux <linux at armlinux.org.uk> [170328 12:17]:
> On Tue, Mar 28, 2017 at 10:09:44AM -0700, Tony Lindgren wrote:
> > OK so how about the following to disable kexec for Andrew's
> > test case?
> That won't work - the hook you're using is to decide whether a particular
> CPU (normally the boot CPU) can be hot-plugged. It isn't expected to
> return false for all.
> The code in question is:
> * Validate that if the current HW supports SMP, then the SW supports
> * and implements CPU hotplug for the current HW. If not, we won't be
> * able to kexec reliably, so fail the prepare operation.
> if (num_possible_cpus() > 1 && platform_can_secondary_boot() &&
> return -EINVAL;
> int platform_can_cpu_hotplug(void)
> #ifdef CONFIG_HOTPLUG_CPU
> if (smp_ops.cpu_kill)
> return 1;
> return 0;
> Platforms don't get a say in that, other than whether they implement
> the operations necessary for hotplug.
Yeah OK so a separate dra7_hs_smp_ops with no cpu_kill initialized
should do the trick, right?
More information about the linux-arm-kernel