[PATCH] mtd: physmap_of: really fix the physmap add-ons

Linus Walleij linus.walleij at linaro.org
Mon Mar 27 06:54:41 PDT 2017

On Sun, Mar 26, 2017 at 2:27 PM, Linus Walleij <linus.walleij at linaro.org> wrote:

> The current way of building the of_physmap add-ons result in just
> the add-on being in the object code, and not the actual core
> implementation and regress the Gemini and Versatile.
> There is no way around exporting these functions. If they are
> built as modules, they will become modules with exported functions,
> if they are builtins they will become builtins.
> Fixes: 4f04f68e1598 ("mtd: physmap_of: fixup gemini/versatile dependencies")
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> The previous attempts to bake a single module from several *optional*
> pieces doesn't play well with tristate, and if there is a way to
> achieve that except making everything an #ifdef in the same file,
> I sure haven't figured it out. I guess #include "physmap_addon.c"
> directly into the C file would work but ugh that is ugly.

Bah, the build servers claim this doesn't work either.

OK investigating again, sigh. Kbuild always bites my ass.

Linus Walleij

More information about the linux-arm-kernel mailing list