[PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio

[Archit Taneja]

Hi,

On 03/07/2017 03:21 AM, Christopher Spinrath wrote:
> Hi Fabio,
>
> On 03/06/2017 10:46 PM, Fabio Estevam wrote:
>> Hi Christopher,
>>
>> On Mon, Mar 6, 2017 at 6:40 PM,  <christopher.spinrath at rwth-aachen.de> wrote:
>>> From: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
>>>
>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio
>>> pin. Since in the DRM world the tfp410 driver is responsible for
>>> handling the connector, add support for hpd gpios in this very driver.
>>>
>>> Signed-off-by: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
>>> ---
>>>  drivers/gpu/drm/bridge/ti-tfp410.c | 72 ++++++++++++++++++++++++++++++++++++--
>>
>> It would be nice to add 'hpd-gpios' property in the binding doc as well:
>> Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
>
> The hpd-gpios property does *not* belong to the ti,tfp410 binding but to the hdmi-connector one
> where it is already documented:
> Documentation/devicetree/bindings/display/connector/hdmi-connector.txt
>
> Unfortunatly, there is no dedicated driver for the connector in Linux; the connector properties have
> to be handled by the encoder (here  the tfp410) driver. Note that this already happens for the
> ddc-i2c-bus property.
>

The patch looks good to me.

Jyri,

Is it possible for you to verify this on Beaglebone platform?

Thanks,
Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project