[PATCH 5/5] ALSA: AACI: Convert to use devm_ioremap_resource()

Russell King - ARM Linux linux at armlinux.org.uk
Sun Mar 26 07:54:09 PDT 2017

On Sun, Mar 26, 2017 at 10:41:54PM +0800, Leo Yan wrote:
> Convert to use devm_ioremap_resource() in probe function, otherwise it's
> missed to unremap this region if probe failed or rmmod module.

Again, wrong - just because there's nothing in the cleanup paths does
not mean it doesn't clean up.

static void aaci_free_card(struct snd_card *card)
        struct aaci *aaci = card->private_data;


This unmaps the mapping you claim it fails to do so.  So, your patch
actually _creates_ bugs that were not there before.


RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

More information about the linux-arm-kernel mailing list