[PATCH 1/7] usb: dwc3: core: fix dwc3_probe() to not do put_sync when get_sync fails

Felipe Balbi balbi at kernel.org
Sat Mar 25 00:52:29 PDT 2017


Hi,

Shuah Khan <shuahkh at osg.samsung.com> writes:
> dwc3_probe() does pm_runtime_put_sync() in its err1 handling when
> pm_runtime_get_sync() fails.  Move the pm_runtime_put_sync() under
> err2 instead as it is used in error paths after pm_runtime_get_sync()
> succeeds.

there's nothing wrong with current code. Read the docs. Even if
pm_runtime_get*() fails, you still need to decrement the usage
counter. pm_runtime_put*() is one way of achieving so.

-- 
balbi



More information about the linux-arm-kernel mailing list