[PATCH V2 4/5] dt-bindings: tegra: Update compatible strings for Tegra flowctrl

Stephen Warren swarren at wwwdotorg.org
Wed Mar 22 12:00:08 PDT 2017


On 03/22/2017 12:13 PM, Jon Hunter wrote:
>
> On 22/03/17 17:26, Stephen Warren wrote:
>> On 03/22/2017 11:00 AM, Jon Hunter wrote:
>>> Update the compatible strings for Tegra Flow Control driver to match
>>> the device-tree source files for Tegra.
>>
>>> +++
>>> b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-flowctrl.txt
>>
>>> +  - "nvidia,tegra124-flowctrl": for Tegra124 and Tegra132
>>
>> I think that should be:
>>
>> +  - "nvidia,tegra124-flowctrl": for Tegra124
>> +  - "nvidia,tegra132-flowctrl", "nvidia,tegra124-flowctrl": for \
>> Tegra132
>
> This is based upon the current tegra132.dtsi file which just has ...
>
> 	flow-controller at 60007000 {
> 		compatible = "nvidia,tegra124-flowctrl";
> 		...
>
> So I can fix-it up if that is what we want/should have. I have a feeling
> there are a few other cases like this.

Yes, I'm sure we have some escapes right now. In practice we currently 
treat T124 and T132 as almost/entirely identical so it won't make any 
difference. In theory it might in the future if we find a T132-specific 
bug (unlikely, but). If you're editing up the compatible value docs, we 
may as well fix this issue while we're at it:-) Scope creep:-) This 
could happen in a separate change if you want, e.g. to make the same 
edit to all T132 or all Tegra DTs.



More information about the linux-arm-kernel mailing list