[PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
jagan at amarulasolutions.com
Wed Mar 22 11:49:02 PDT 2017
On Thu, Mar 23, 2017 at 12:14 AM, Dmitry Torokhov
<dmitry.torokhov at gmail.com> wrote:
> On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
>> On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
>> <dmitry.torokhov at gmail.com> wrote:
>> > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
>> >> From: Jagan Teki <jagan at amarulasolutions.com>
>> >> Added missing of_match_table for max11801_ts driver with
>> >> compatible as "maxim,max11801_ts"
>> > Why not "maxim,max11801"? Also, I think we'd need a binding document.
>> Compatibility purpose to make this is for touchscreen and few of other
> Compatibility with what? The i2c id is "max11801" (without the "-ts").
Do we need to sync with i2c id as well? egalax_ts.c follow "_ts"
of-course the i2c there as follow the same.
>> *_ts.c files follow the same, and added binding documentation in 2/3
> Sorry, it seems I am only copied on 1/3 patch.
Sorry, will add in next version patches.
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
More information about the linux-arm-kernel