[PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table

Dmitry Torokhov dmitry.torokhov at gmail.com
Wed Mar 22 11:30:39 PDT 2017


On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan at amarulasolutions.com>
> 
> Added missing of_match_table for max11801_ts driver with
> compatible as "maxim,max11801_ts"
> 

Why not "maxim,max11801"? Also, I think we'd need a binding document.

> Cc: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Matteo Lisi <matteo.lisi at engicam.com>
> Cc: Michael Trimarchi <michael at amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> ---
> Changes for v7:
> - newly added patch
> 
>  drivers/input/touchscreen/max11801_ts.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> index a595ae5..5085d4f 100644
> --- a/drivers/input/touchscreen/max11801_ts.c
> +++ b/drivers/input/touchscreen/max11801_ts.c
> @@ -224,9 +224,16 @@ static int max11801_ts_probe(struct i2c_client *client,
>  };
>  MODULE_DEVICE_TABLE(i2c, max11801_ts_id);
>  
> +static const struct of_device_id max11801_ts_dt_ids[] = {
> +	{ .compatible = "maxim,max11801_ts" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, max11801_ts_dt_ids);
> +
>  static struct i2c_driver max11801_ts_driver = {
>  	.driver = {
>  		.name	= "max11801_ts",
> +		.of_match_table	= max11801_ts_dt_ids,
>  	},
>  	.id_table	= max11801_ts_id,
>  	.probe		= max11801_ts_probe,
> -- 
> 1.9.1
> 

-- 
Dmitry



More information about the linux-arm-kernel mailing list