[PATCH 8/9] KVM: arm/arm64: vgic: Don't check vgic_initialized in flush_hwstate

Christoffer Dall cdall at linaro.org
Tue Mar 21 05:30:51 PDT 2017


On Tue, Mar 21, 2017 at 12:08:15PM +0000, Marc Zyngier wrote:
> On 20/03/17 10:58, Christoffer Dall wrote:
> > Now when we do an early init of the static parts of the VGIC data
> > structures, we can do things like checking if the AP lists are empty
> > directly without having to explicitly check if the vgic is initialized
> > and reduce a bit of work in our criticial path.
> 
>                                   critical
> 
> > Note: list_empty is a single atomic read (uses READ_ONCE) and can
> > therefore check if a list is empty or not without the need to take the
> > spinlock protecting the list.
> 
> This note might be better placed in patch #2.

Agreed.

> 
> > 
> > Signed-off-by: Christoffer Dall <cdall at linaro.org>
> 
> Acked-by: Marc Zyngier <marc.zyngier at arm.com>
> 

Thanks,
-Christoffer



More information about the linux-arm-kernel mailing list