[PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg callback
Lucas Stach
l.stach at pengutronix.de
Mon Mar 20 02:43:47 PDT 2017
Am Montag, den 20.03.2017, 14:15 +0800 schrieb Dong Aisheng:
> It is not really necessary to provide the current .readable_reg
> implementation as we know what we're doing in our driver
> and the regmap core has already done the partial check for
> available maximum regs.
>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Signed-off-by: Dong Aisheng <aisheng.dong at nxp.com>
Acked-by: Lucas Stach <l.stach at pengutronix.de>
> ---
> drivers/soc/imx/gpc.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index a744f7e..4885ec2 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -284,18 +284,10 @@ static const struct of_device_id imx_gpc_dt_ids[] = {
> { }
> };
>
> -static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg)
> -{
> - return (reg % 4 == 0) && (reg <= 0x2ac);
> -}
> -
> static const struct regmap_config imx_gpc_regmap_config = {
> .reg_bits = 32,
> .val_bits = 32,
> .reg_stride = 4,
> -
> - .readable_reg = imx_gpc_readable_reg,
> -
> .max_register = 0x2ac,
> };
>
More information about the linux-arm-kernel
mailing list