[PATCH] clk: sunxi-ng: fix recalc_rate formula of NKMP clocks

Maxime Ripard maxime.ripard at free-electrons.com
Mon Mar 20 02:33:55 PDT 2017

On Sat, Mar 18, 2017 at 04:19:43AM +0800, Icenowy Zheng wrote:
> In commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets"), the
> final formula of NKMP clocks' recalc_rate is refactored; however, the
> refactored formula broke the calculation due to some C language operand
> priority problem -- the priority of operand >> is lower than * and /,
> makes the formula being parsed as "(parent_rate * n * k) >> (p / m)", but
> it should be "(parent_rate * n * k >> p) / m".
> Add the pair of parentheses to fix up this issue. This pair of
> parentheses used to exist in the old formula.
> Fixes: commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets")

You shouldn't have commit here.

> Signed-off-by: Icenowy Zheng <icenowy at aosc.xyz>

Fixed it, and applied, thanks!

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170320/5741ef4a/attachment.sig>

More information about the linux-arm-kernel mailing list