[PATCH] spi: davinci: add comment about dummy tx buffer usage
Frode Isaksen
fisaksen at baylibre.com
Fri Mar 17 08:41:10 PDT 2017
Add explanation about using the the rx buffer as the
dummy tx buffer.
Signed-off-by: Frode Isaksen <fisaksen at baylibre.com>
---
drivers/spi/spi-davinci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index f37bbdd..595acdc 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -660,7 +660,11 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t)
goto err_desc;
if (!t->tx_buf) {
- /* use rx buffer as dummy tx buffer */
+ /* To avoid errors when doing rx-only transfers with
+ * many SG entries (> 20), use the rx buffer as the
+ * dummy tx buffer so that dma reloads are done at the
+ * same time for rx and tx.
+ */
t->tx_sg.sgl = t->rx_sg.sgl;
t->tx_sg.nents = t->rx_sg.nents;
}
--
2.7.4
More information about the linux-arm-kernel
mailing list