[PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn
Joe Perches
joe at perches.com
Wed Mar 15 07:17:24 PDT 2017
On Wed, 2017-03-15 at 12:23 +0000, Lee Jones wrote:
> On Tue, 14 Mar 2017, Joe Perches wrote:
[]
> > never break user-visible strings such as
> > printk messages, because that breaks the ability to grep for them.
>
> Right, I'm aware of this. I'm also aware of the other rule we have
> where lines are not to exceed 80 chars. Hence my question; "is the 80
> chars rule the lessor sin of the two".
>
> Rock <=> hard place
>
> Actually I would say that the error message sub-optimal and could, in
> fact be edited to be more succinct, thus not breaking any rules.
It's not a 'sin' at all.
The rule is to exceed 80 columns when the logging
message format is long.
I didn't even look at the format content.
Change it if you wish.
More information about the linux-arm-kernel
mailing list