From: Iyappan Subramanian <isubramanian at apm.com> Date: Fri, 3 Mar 2017 17:09:28 -0800 > +void xge_mac_set_station_addr(struct xge_pdata *pdata) > +{ > + u32 addr0, addr1; > + u8 *dev_addr = pdata->ndev->dev_addr; Please order local variable declarations from longest to shortest line.