[PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook
boris.brezillon at free-electrons.com
Tue Mar 7 10:34:41 PST 2017
On Tue, 7 Mar 2017 21:04:50 +0900
Masahiro Yamada <yamada.masahiro at socionext.com> wrote:
> Hi Boris,
> 2017-02-20 21:28 GMT+09:00 Boris Brezillon <boris.brezillon at free-electrons.com>:
> > The last/only user of the chip->write_page() hook (the Atmel NAND
> > controller driver) has been reworked and is no longer specifying a custom
> > ->write_page() implementation.
> > Drop this hook before someone else start abusing it.
> > Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Just a minor comment.
> * nand_write_page - [REPLACEABLE] write one page
> * @mtd: MTD device structure
> Can you update the comment block for nand_write_page(), too?
> [REPLACEABLE] -> [INTERNAL]
I think I'll just drop it, it does not mean anything to flag a static
function as replaceable (the ->write_page() method could be overloaded,
but not the nand_write_page() implementation itself).
More information about the linux-arm-kernel