[PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage

Linus Walleij linus.walleij at linaro.org
Fri Jun 16 02:18:38 PDT 2017


On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT
<gregory.clement at free-electrons.com> wrote:

> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself but
> the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham at alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser at gmail.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Tested-by: Ralph Sennhauser <ralph.sennhauser at gmail.com>
> Tested-by: Chris Packham <Chris.Packham at alliedtelesis.co.nz>
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>

Already applied this patch, sorry for missing the resend in the series.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list