[PATCH v2] gpio: mvebu: fix regmap_update_bits usage
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Jun 9 04:01:25 PDT 2017
Hello,
On Fri, 9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote:
> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself but
> the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham at alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser at gmail.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Thanks for fixing this so quickly!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list