[PATCHv2 1/2] gpio: mvebu: fix blink counter register selection
Ralph Sennhauser
ralph.sennhauser at gmail.com
Fri Jun 9 01:03:22 PDT 2017
On Fri, 9 Jun 2017 09:37:55 +0200
Linus Walleij <linus.walleij at linaro.org> wrote:
> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud
> <richard.genoud at gmail.com> wrote:
>
> > The blink counter A was always selected because 0 was forced in the
> > blink select counter register.
> > The variable 'set' was obviously there to be used as the register
> > value, selecting the B counter when id==1 and A counter when id==0.
> >
> > Tested on clearfog-pro (Marvell 88F6828)
> >
> > Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
> > Reviewed-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> > Reviewed-by: Ralph Sennhauser <ralph.sennhauser at gmail.com>
> > Signed-off-by: Richard Genoud <richard.genoud at gmail.com>
>
> Patch applied for fixes.
>
> It appears this will clash with patches on the development branch :(
Hi Linus,
The commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
access") which you likely mean breaks gpio-keys, reported about an hour
ago, so you might just want to drop that one for now instead as it
needs mor work anyway.
Ralph
More information about the linux-arm-kernel
mailing list