[PATCH 2/2 v4] clk: Add Gemini SoC clock controller

Linus Walleij linus.walleij at linaro.org
Thu Jun 8 05:18:02 PDT 2017


On Mon, Jun 5, 2017 at 9:58 PM, Stephen Boyd <sboyd at codeaurora.org> wrote:
> On 06/05, Linus Walleij wrote:
>> On Thu, Jun 1, 2017 at 9:02 AM, Stephen Boyd <sboyd at codeaurora.org> wrote:
>>
>> >> +CLK_OF_DECLARE_DRIVER(gemini_cc, "cortina,gemini-syscon", gemini_cc_init);
>> >
>> > Is there a reason why this isn't a platform driver?
>>
>> I can't get the platform to boot if I try, I guess because the console
>> UART needs the clock like super-early.
>>
>> I fixed all the other issues, resending soon.
>>
>
> Does the console uart driver support probe defer?

It's the 8250_of.c driver.

It's such a big driver that I don't dare to say, I guess I would
have to go in and debug and patch around in the 8250 driver
if you insist.

But I'm not even sure that is the problem actually, I'd have to
analyze.

I think the timer may be more of an issue...

It is using CLOCKSOURCE_OF_DECLARE(), at least last time
I checked there was no such thing as clocksources retrying their
calls, and that cannot be regular probes because of, yeah device
core is using the timer, I think.

Yeah I looked in:
drivers/clocksource/clksrc-probe.c

It will just fail if it can't initialize the clocksource.

I don't understand what platforms can actually get their timers
up at all without the clock framework? Those hardcoding the
clock frequency in the device tree, or things like the ARM
TWD which has it encoded in hardware perhaps?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list