[PATCH 4/9] net: mvmdio: move the read valid check into its own function

Antoine Tenart antoine.tenart at free-electrons.com
Wed Jun 7 07:43:08 PDT 2017


Hello,

On Wed, Jun 07, 2017 at 01:00:21PM +0300, Sergei Shtylyov wrote:
> On 6/7/2017 11:38 AM, Antoine Tenart wrote:
> > 
> > -	val = readl(dev->regs);
> > -	if (!(val & MVMDIO_SMI_READ_VALID)) {
> > +	if (orion_mdio_smi_is_read_valid(dev)) {
> >  		dev_err(bus->parent, "SMI bus read not valid\n");
> 
>    I think you reversed the valuid/invalid sense in the new function's name.

Good catch, I'll fix this.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170607/61219f52/attachment.sig>


More information about the linux-arm-kernel mailing list