[PATCH] arm64: dts: marvell: cp110: add required clocks for mdio interface

Gregory CLEMENT gregory.clement at free-electrons.com
Tue Jun 6 03:05:24 PDT 2017


Hi Thomas,
 
 On mar., juin 06 2017, Thomas Petazzoni <thomas.petazzoni at free-electrons.com> wrote:

> From: Russell King <rmk+kernel at armlinux.org.uk>
>
> Add the three required clocks for the MDIO interface to be functional

You should also maybe update the commit log and speaking of two clocks
as you removed the third one.


> on Armada 8k platforms.  Without this, the CPU hangs, causing RCU
> stalls or the system to become unresponsive.

According to this comment, I guess this patch is a fix and should be
applied in v4.12-rc.

Gregory

>
> Signed-off-by: Russell King <rmk+kernel at armlinux.org.uk>
> [Thomas:
>  - remove mg_core_clock, since it's a parent of mg_clock
>  - also add clock references to the slave CP mdio instance]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 1 +
>  arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> index 00af338..c33e891 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> @@ -95,6 +95,7 @@
>  				#size-cells = <0>;
>  				compatible = "marvell,orion-mdio";
>  				reg = <0x12a200 0x10>;
> +				clocks = <&cpm_syscon0 1 9>, <&cpm_syscon0 1 5>;
>  			};
>  
>  			cpm_icu: interrupt-controller at 1e0000 {
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> index bee48ae..2a99ff8 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
> @@ -100,6 +100,7 @@
>  				#size-cells = <0>;
>  				compatible = "marvell,orion-mdio";
>  				reg = <0x12a200 0x10>;
> +				clocks = <&cps_syscon0 1 9>, <&cps_syscon0 1 5>;
>  			};
>  
>  			cps_icu: interrupt-controller at 1e0000 {
> -- 
> 2.7.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list