[PATCH] arm64: dts: marvell: 8040-mcbin: Enable 1GB Ethernet
Marc Zyngier
marc.zyngier at arm.com
Tue Jun 6 01:21:58 PDT 2017
Hi Andrew,
On 05/06/17 22:16, Andrew Lunn wrote:
>> +&cps_eth1 {
>> + status = "okay";
>> + phy = <&phy0>;
>> + phy-mode = "sgmii";
>> +};
>
> Hi Marc
>
> Documentation/devicetree/bindings/net/ethernet.txt says:
>
> - phy-handle: phandle, specifies a reference to a node representing a PHY
> device; this property is described in ePAPR and so preferred;
> - phy: the same as "phy-handle" property, not recommended for new bindings.
Happy to amend the patch, though armada-8040-db.dts is already using
"phy" (and not "phy-handle"). Should that one be fixed as well in the
name of consistency? Also,
Documentation/devicetree/bindings/net/marvell-pp2.txt only mentions the
"phy" property. If feels a bit odd not to at least recommend the new
property in the binding documentation.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
More information about the linux-arm-kernel
mailing list