Small issue with 3fde2999fac5 "arm64: cpufeature: Don't dump useless backtrace on CPU_OUT_OF_SPEC"

Heiner Kallweit hkallweit1 at gmail.com
Mon Jun 5 02:20:53 PDT 2017


Am 05.06.2017 um 10:48 schrieb Mark Rutland:
> Hi,
> 
> On Sun, Jun 04, 2017 at 02:53:36PM +0200, Heiner Kallweit wrote:
>> The warning is printed unconditionally. An "if (taint)" seems to be
>> missing.
> 
> I'm not sure I follow. We're using pr_warn_once(), which should only
> print the message once, regardless of how many times it is called.
> 
Before we had WARN_TAINT_ONCE(taint, ..), so the warning is
triggered by taint != 0.
Now the warning is printed (just once but) even if taint == 0.

> Is that not working correctly for you?
> 
> If so, could you please report so on LAKML? That way others can get
> involved with investigating and fixing the issue.
> 
> Thanks,
> Mark.
> 

Rgds, Heiner



More information about the linux-arm-kernel mailing list