[PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

Frank Wang frank.wang at rock-chips.com
Sun Jun 4 20:51:00 PDT 2017


Hi Finley,

On 2017/5/12 10:44, Finley Xiao wrote:
> This adds the necessary data for handling eFuse on the rk322x.
>
> Signed-off-by: Finley Xiao <finley.xiao at rock-chips.com>
> ---
>   Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
>   drivers/nvmem/rockchip-efuse.c                             | 4 ++++
>   2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 94aeeea..194926f 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
>   - compatible: Should be one of the following.
>     - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
>     - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> +  - "rockchip,rk322x-efuse" - for RK322x SoCs.

As the comments from Heiko in other patches, compatibles should not 
contain wildcards, so could you please make this
     "rockchip,rk3228-efuse"
instead?

>     - "rockchip,rk3288-efuse" - for RK3288 SoCs.
>     - "rockchip,rk3399-efuse" - for RK3399 SoCs.
>   - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index 423907b..a0d4ede 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
>   		.data = (void *)&rockchip_rk3288_efuse_read,
>   	},
>   	{
> +		.compatible = "rockchip,rk322x-efuse",
> +		.data = (void *)&rockchip_rk3288_efuse_read,
> +	},

The same as above.


BR.
Frank

> +	{
>   		.compatible = "rockchip,rk3288-efuse",
>   		.data = (void *)&rockchip_rk3288_efuse_read,
>   	},





More information about the linux-arm-kernel mailing list