[PATCH] ARM: dts: imx: Fix Ethernet PHY reset polarity

Andrew Lunn andrew at lunn.ch
Sun Jun 4 11:49:37 PDT 2017


On Sun, Jun 04, 2017 at 02:31:15PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> The FEC driver ignores the GPIO polarity from 'phy-reset-gpios' and
> considers that the Ethernet PHY is active low, unless the
> property 'phy-reset-active-high' is present.
> 
> Fix the device tree description by explicitly passing the 
> 'GPIO_ACTIVE_LOW' flag to the 'phy-reset-gpios' property.

Hi Fabio

Device tree bindings are supposed to be stable. So we can never fix
the FEC to respect the flag. This change to 'GPIO_ACTIVE_LOW' makes
the suggestion the flag is used, and can be set to GPIO_ACTIVE_HIGH.
If i were to change the value, i would set it to 42, or something new
like GPIO_FLAGS_BROKEN.

     Andrew



More information about the linux-arm-kernel mailing list