[PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver
Pavel Machek
pavel at ucw.cz
Sat Jun 3 12:51:39 PDT 2017
Hi!
> >>>+ /* Auto/manual exposure */
> >>>+ ctrls->auto_exp = v4l2_ctrl_new_std_menu(hdl, ops,
> >>>+ V4L2_CID_EXPOSURE_AUTO,
> >>>+ V4L2_EXPOSURE_MANUAL, 0,
> >>>+ V4L2_EXPOSURE_AUTO);
> >>>+ ctrls->exposure = v4l2_ctrl_new_std(hdl, ops,
> >>>+ V4L2_CID_EXPOSURE_ABSOLUTE,
> >>>+ 0, 65535, 1, 0);
> >>
> >>Is exposure_absolute supposed to be in microseconds...?
> >
> >Yes.
>
> According to the docs V4L2_CID_EXPOSURE_ABSOLUTE is in 100 usec units.
>
> OTOH V4L2_CID_EXPOSURE has no defined unit, so it's a better fit IMO.
> >Way more drivers appear to be using EXPOSURE than EXPOSURE_ABSOLUTE, too.
>
> Done, switched to V4L2_CID_EXPOSURE. It's true, this control is not
> taking 100 usec units, so unit-less is better.
Thanks. If you know the units, it would be of course better to use
right units...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170603/64113cea/attachment.sig>
More information about the linux-arm-kernel
mailing list