[PATCH] ARM: dts: da850-evm: fix tca6416 for use with GPIO hogs
Sekhar Nori
nsekhar at ti.com
Thu Jun 1 23:01:11 PDT 2017
Hi Kevin,
On Wednesday 31 May 2017 06:51 AM, Kevin Hilman wrote:
> In order GPIOS from this controller to be used with the "gpio-hogs"
> property, the tca6416 node has to properly labeled as a gpio-controller,
> and use #gpio-cells.
>
> With that, the SEL_A, SEL_B, SEL_C lines that are used to select VPIF
> input can be configured using GPIO hogs.
>
> As an example, example, the configuration below selects the analog video
> input on the da850-evm UI board:
>
> &tca6416 {
> status = "okay";
>
> sel_a {
> gpio-hog;
> gpios = <7 GPIO_ACTIVE_HIGH>;
> output-high;
> line-name = "ADC_ENn";
> };
> sel_b {
> gpio-hog;
> gpios = <6 GPIO_ACTIVE_HIGH>;
> output-high;
> line-name = "CAMERA_ENn";
> };
> sel_c {
> gpio-hog;
> gpios = <5 GPIO_ACTIVE_HIGH>;
> output-low;
> line-name = "VIDEO_IN_ENn";
> };
> };
>
> Signed-off-by: Kevin Hilman <khilman at baylibre.com>
This patch looks good to me. On the topic of using gpio hogs for this
sort of thing, in the past I felt using enable-gpios property is better.
My reasoning given to Bartosz is here:
https://patchwork.kernel.org/patch/9578031/
Thanks,
Sekhar
More information about the linux-arm-kernel
mailing list