[PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

[Russell King - ARM Linux]

On Thu, Jun 01, 2017 at 01:53:21AM +0100, Jose Abreu wrote:
> Hi Russell,
> 
> 
> On 30-05-2017 15:23, Russell King wrote:
> > +static int dw_hdmi_cec_transmit(struct cec_adapter *adap, u8 attempts,
> > +				u32 signal_free_time, struct cec_msg *msg)
> > +{
> > +	struct dw_hdmi_cec *cec = adap->priv;
> > +	unsigned i;
> > +
> > +	cec->retries = attempts;
> 
> I think you should check first if CEC engine is in normal
> operation mode, as a safety measure.

I'm not sure what you mean there, because the iMX6 manuals don't mention
anything about that.  The only "modes" it talks about is initiator mode
and follower mode.  Moreover, there's nothing in what was FSL's driver
that hints at that either.

Maybe you could provide some further technical information on this
point?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.