[PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins

[Timur Tabi]

On 07/14/2017 04:46 PM, Stephen Boyd wrote:
> Right, the gpiolib core would need to be updated to request the
> gpio in gpiochip_add_data() around the loop where it goes and
> configures things. And it could ignore ones that it can't request
> there.

__gpiod_request already calls chip->request(), so this would need to be 
a temporary request.  It seems a bit hackish, but I'll try it.

BTW, I noticed that __gpiod_free() does this:

	if (chip->free) {
		spin_unlock_irqrestore(&gpio_lock, flags);
--->		might_sleep_if(chip->can_sleep);
		chip->free(chip, gpio_chip_hwgpio(desc));
		spin_lock_irqsave(&gpio_lock, flags);


Should __gpiod_request() also call might_sleep_if()?

	if (chip->request) {
		/* chip->request may sleep */
		spin_unlock_irqrestore(&gpio_lock, flags);
---> missing call to might_sleep_if() here?
		status = chip->request(chip, gpio_chip_hwgpio(desc));
		spin_lock_irqsave(&gpio_lock, flags);


-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.