[PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support

[Biju Das]

Hi Simon,

Thanks for the review.

Regards,
Biju

> -----Original Message-----
> From: Simon Horman [mailto:horms at verge.net.au]
> Sent: 10 July 2017 09:37
> To: Geert Uytterhoeven <geert at linux-m68k.org>
> Cc: Mark Rutland <mark.rutland at arm.com>; devicetree at vger.kernel.org;
> Chris Paterson <Chris.Paterson2 at renesas.com>; Sergei Shtylyov
> <sergei.shtylyov at cogentembedded.com>; Magnus Damm
> <magnus.damm at gmail.com>; Russell King <linux at armlinux.org.uk>; Biju Das
> <biju.das at bp.renesas.com>; Linux-Renesas <linux-renesas-
> soc at vger.kernel.org>; Rob Herring <robh+dt at kernel.org>; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> On Mon, Jul 10, 2017 at 10:23:51AM +0200, Simon Horman wrote:
> > On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> > > Hi Biju,
> > >
> > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das at bp.renesas.com> wrote:
> > > > Add Ethernet AVB support for r8a7743 SoC.
> > > >
> > > > Signed-off-by: Biju Das <biju.das at bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <chris.paterson2 at renesas.com>
> > >
> > > With the minor nit below fixed:
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > >
> > > > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > > > @@ -605,6 +605,19 @@
> > > >                         #size-cells = <0>;
> > > >                         status = "disabled";
> > > >                 };
> > > > +
> > > > +               avb: ethernet at e6800000 {
> > > > +                       compatible = "renesas,etheravb-r8a7743",
> >
> > I do not see a patch to add "renesas,etheravb-r8a7743" to
> > Documentation/devicetree/bindings/net/renesas,ravb.txt
> >
> > If you haven't already done so please post a patch to add this once
> > net-next re-opens.
>
> I now see "ravb: Document binding for r8a7743 SoC"

I will send the patch with Rob's comments.
> >
> > > > +                                    "renesas,etheravb-rcar-gen2";
> > > > +                       reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > > > +                       interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
> > >
> > > s/0/GIC_SPI/
> >
> > Thanks, I have applied this patch with the minor update above.

Thanks Simon.




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.