[PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support

Biju Das biju.das at bp.renesas.com
Mon Jul 10 01:21:45 PDT 2017


Hi Geert,
Thanks for the review.

> -----Original Message-----
> From: geert.uytterhoeven at gmail.com [mailto:geert.uytterhoeven at gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <biju.das at bp.renesas.com>
> Cc: Rob Herring <robh+dt at kernel.org>; Mark Rutland
> <mark.rutland at arm.com>; Russell King <linux at armlinux.org.uk>; Sergei
> Shtylyov <sergei.shtylyov at cogentembedded.com>; Simon Horman
> <horms at verge.net.au>; Magnus Damm <magnus.damm at gmail.com>; Chris
> Paterson <Chris.Paterson2 at renesas.com>; devicetree at vger.kernel.org; Linux-
> Renesas <linux-renesas-soc at vger.kernel.org>; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das at bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das at bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2 at renesas.com>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 };
> > +
> > +               avb: ethernet at e6800000 {
> > +                       compatible = "renesas,etheravb-r8a7743",
> > +                                    "renesas,etheravb-rcar-gen2";
> > +                       reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > +                       interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>

OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.


More information about the linux-arm-kernel mailing list