[PATCH] arm64: dts: marvell: mcbin: Enable PCIe interface

[Gregory CLEMENT]

Hi Ard,
 
 On jeu., juil. 06 2017, Ard Biesheuvel <ard.biesheuvel at linaro.org> wrote:

> On 6 July 2017 at 07:31, Jisheng Zhang <jszhang at marvell.com> wrote:
>> On Wed, 5 Jul 2017 18:44:03 +0100 Russell King - ARM Linux wrote:
>>
>>> On Wed, Jul 05, 2017 at 06:36:53PM +0100, Ard Biesheuvel wrote:
>>> > On 5 July 2017 at 18:16, Russell King - ARM Linux <linux at armlinux.org.uk> wrote:
>>> > > On Wed, Jul 05, 2017 at 06:13:33PM +0200, Gregory CLEMENT wrote:
>>> > >> Enable the PCIe interface on the MACCHIATOBin board. It is located on
>>> > >> CON12 and is 4 lanes capable.
>>> > >>
>>> > >> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
>>> > >
>>> > > Why do you folk at free-electrons like doing half a job all the friggin
>>> > > time?
>>> > >
>>> > > You know I have complete patches for mcbin, but you pointedly won't look
>>> > > at them at all - except when you have a problem and want to test my tree.
>>> > > And even then, you ignore my work (despite testing that it works), and
>>> > > you still recreate my patches.
>>> > >
>>> > > This is really frustrating and insane behaviour on your part.
>>> > >
>>> > > Here's what I have:
>>> > >
>>> > > +&cpm_pcie0 {
>>> > > +       pinctrl-names = "default";
>>> > > +       pinctrl-0 = <&cpm_pcie_pins>;
>>> > > +       num-lanes = <4>;
>>> > > +       reset-gpio = <&cpm_gpio1 20 GPIO_ACTIVE_LOW>;
>>> > > +       status = "okay";
>>> >
>>> > This needs 'num-viewport = <8>' as well, or the crazy Synopsys DWC
>>
>> IMHO, maybe putting this property into dtsi is better.
>>
>
> Good point. Do all instances of this IP that live on the SoC have 8
> viewports?

In the Armada 80x0 datasheet there is no mention of viewport. However 2
days ago you said that "What I do know is that boards like the Marvell
8040 based MacchiatoBin uses this IP in RC mode, and exposes config,
MMIO and IO space windows using only 2 viewports. Note that this is
essentially a bug in the DT description, given that its version of the
IP supports 8 viewports."[1]

So you seem to know that the version of the IP used support the 8
viewports!

What I can also say is that the in the datasheet there is no mention of
difference between the instance. The only thing that can differ is the
number of lane for each PCIe Port.

Gregory


[1]: https://www.spinics.net/lists/arm-kernel/msg592091.html

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com