[PATCH 0/8] EDAC drivers for Armada XP L2 and DDR

Chris Packham Chris.Packham at alliedtelesis.co.nz
Sun Jul 2 14:59:12 PDT 2017


On 01/07/17 02:51, Jan Luebbe wrote:
> This series adds drivers for the L2 cache and DDR RAM ECC functionality as
> found on the MV78230/MV78x60 SoCs. I've tested these changes with the MV78460
> (on a custom board with a DDR3 ECC DIMM).
> 
> Also contained in this series are an additional debugfs wrapper and devm_
> helpers for edac_mc_/edac_device_ allocation and registration, which make error
> handing and cleanup simpler.
> 
> Compared to the previous RFC series, the following changes have been made:
> - Integrated Chris' patches for parity and ECC configuration via DT
> - Merged the DDR RAM and L2 cache drivers (as requested by Borislav, analogous
>    to fsl_ddr_edac.c and mpc85xx_edac.c)
> - Added myself to MAINTAINERS (requested by Borislav)
> - L2 cache: Track the msg size and use snprintf (review comment by Chris)
> - L2 cache: Split error injection from the check function (review comment by
>    Chris)
> - DDR RAM: Allow 16 bit width in addition to 32 and 64 bit (review comment by
>    Chris)
> - Use of_match_ptr() (review comments by Chris)
> - Minor checkpatch cleanups
> 
> Chris: To actually make use of this with 16 bit width, you'd need to add a new
> DT compatible, which could be done in a follow up patch. Is your SoC considered
> a armada-xp variant?

By Marvell's marketing department yes. The truth is a little murkier, 
I'd say the Armada-XP and Armada-XP-98dx3236 share a common ancestor. 
For the SDRAM controller saying it's a variant with a 16-bit bus is 
appropriate.

> 
> Chris Packham (2):
>    ARM: l2x0: support parity-enable/disable on aurora
>    ARM: l2x0: add arm,ecc-enable property for aurora
> 
> Jan Luebbe (6):
>    ARM: l2c: move cache-aurora-l2.h to asm/hardware
>    ARM: aurora-l2: add prefix to MAX_RANGE_SIZE
>    EDAC: Add missing debugfs_create_x32 wrapper
>    EDAC: Add devres helpers for
>      edac_mc_alloc/edac_mc_add_mc(_with_groups)
>    EDAC: Add devres helpers for
>      edac_device_alloc_ctl_info/edac_device_add_device
>    EDAC: Add driver for the Marvell Armada XP SDRAM and L2 cache ECC
> 
>   Documentation/devicetree/bindings/arm/l2c2x0.txt |   2 +
>   MAINTAINERS                                      |   6 +
>   arch/arm/include/asm/hardware/cache-aurora-l2.h  | 103 ++++
>   arch/arm/mm/cache-aurora-l2.h                    |  55 --
>   arch/arm/mm/cache-l2x0.c                         |  20 +-
>   drivers/edac/Kconfig                             |   7 +
>   drivers/edac/Makefile                            |   1 +
>   drivers/edac/armada_xp_edac.c                    | 639 +++++++++++++++++++++++
>   drivers/edac/debugfs.c                           |  11 +
>   drivers/edac/edac_device.c                       |  59 +++
>   drivers/edac/edac_device.h                       |  29 +
>   drivers/edac/edac_mc.c                           |  53 ++
>   drivers/edac/edac_mc.h                           |  26 +
>   drivers/edac/edac_module.h                       |   5 +
>   14 files changed, 958 insertions(+), 58 deletions(-)
>   create mode 100644 arch/arm/include/asm/hardware/cache-aurora-l2.h
>   delete mode 100644 arch/arm/mm/cache-aurora-l2.h
>   create mode 100644 drivers/edac/armada_xp_edac.c
> 




More information about the linux-arm-kernel mailing list