[PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Vivien Didelot
vivien.didelot at savoirfairelinux.com
Thu Jan 19 14:26:03 PST 2017
Gregory CLEMENT <gregory.clement at free-electrons.com> writes:
> +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> +{
> + return chip->info->family == MV88E6XXX_FAMILY_6341;
> +}
I don't want to see these erronous family checks anymore, but I cannot
blame you for adding it since not all the code is moved to ops yet ;)
> MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
> MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
> MV88E6XXX_FAMILY_6320, /* 6320 6321 */
> + MV88E6XXX_FAMILY_6341, /* 6141 6341 */
Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
family of switch chips?
> MV88E6XXX_FAMILY_6351, /* 6171 6175 6350 6351 */
> MV88E6XXX_FAMILY_6352, /* 6172 6176 6240 6352 */
> MV88E6XXX_FAMILY_6390, /* 6190 6190X 6191 6290 6390 6390X */
Otherwise the patch looks good.
Thanks,
Vivien
More information about the linux-arm-kernel
mailing list